[W1][Codeunit][8900][Email Impl] SourceRecordRef.ReadPermission() condition was removed from FilterRemovedSourceRecords-procedure. Fixes AB#8635#8708
Open
dkastena wants to merge 3 commits into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
If at least one security filter is applied to the “Purchase Header” table, the user will have a problem when pushing the 'Add file from source document’ action on the “Email Attachments” subpage.
Result:
Message: "Did not find any attachments related to this email"
Expected result:
The page should show the list of attachments from the source purchase document. Like it works without applying security filters.
Linked work
Fixes AB#8635
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
GetBySystemId() already respects the user's security filter.
The blanket ReadPermission() check was the real problem because it:
By removing it, we let GetBySystemId() do what it's designed to do—check permissions filter-aware.
Risk & compatibility